Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3Bucket for mypy #33028

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add S3Bucket for mypy #33028

merged 1 commit into from
Aug 3, 2023

Conversation

kimdwkimdw
Copy link
Contributor

@kimdwkimdw kimdwkimdw commented Aug 2, 2023 •
edited
Loading

Fixing Simple mypy typing for S3Bucket.

For example, this code cannot pass mypy typing because of get_bucket return simple 'object'

airflow/airflow/providers/amazon/aws/hooks/s3.py

Line 301 in df74553

def get_bucket(self, bucket_name: str | None = None) -> object: 

from airflow.providers.amazon.aws.hooks.s3 import S3Hook

s3_hook = S3Hook(aws_conn_id=aws_s3_conn_id, verify=verify)
objects = s3_hook.get_bucket(self.s3_bucket).objects

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Aug 2, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 2, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@vincbeck
Copy link
Contributor

vincbeck commented Aug 2, 2023 •
edited
Loading

Please run static checks, they are currently failing. You can either use Breeze or pre-commit, everything should be explained in the README I linked

@kimdwkimdw kimdwkimdw force-pushed the patch-1 branch 2 times, most recently from c192898 to 41b2c96 Compare August 3, 2023 02:17
@kimdwkimdw
Copy link
Contributor Author

kimdwkimdw commented Aug 3, 2023 •
edited
Loading

@vincbeck Thanks. I applied pre-commit and rebase on current main branch.
(specifically modified from black)

@vincbeck
Copy link
Contributor

vincbeck commented Aug 3, 2023

Nice! Thanks for doing the change!

@vincbeck vincbeck merged commit 44234c2 into apache:main Aug 3, 2023
42 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 3, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal mentioned this pull request Aug 4, 2023
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincbeck vincbeck vincbeck approved these changes

@Lee-W Lee-W Lee-W approved these changes

@uranusjr uranusjr uranusjr approved these changes

@eladkal eladkal Awaiting requested review from eladkal

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

Assignees
No one assigned
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimdwkimdw @vincbeck @uranusjr @Lee-W